Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node "status" and "scheduling eligibility" tags to client metrics #6130

Merged

Conversation

pete-woods
Copy link
Contributor

When summing up the capability of your Nomad fleet for scaling purposes, it's important to exclude draining nodes, as they won't accept new jobs.

Hi @langmartin and @schmichael, here's another PR from CircleCI. This should hopefully be the last one we need to use Nomad's built-in metrics for our scaling.

When summing up the capability of your Nomad fleet for scaling purposes, it's important to exclude draining nodes, as they won't accept new jobs.
@jippi
Copy link
Contributor

jippi commented Aug 14, 2019

@pete-woods next step is to open source your scaler :D

@pete-woods
Copy link
Contributor Author

@pete-woods next step is to open source your scaler :D

Alas, that's not my call!

@langmartin langmartin self-requested a review August 16, 2019 18:10
@pete-woods
Copy link
Contributor Author

Hi folks! Any feedback on this?

@langmartin langmartin added this to the 0.10.0 milestone Aug 28, 2019
@pete-woods
Copy link
Contributor Author

Thanks! 👍

@pete-woods
Copy link
Contributor Author

At the risk of nagging again, pinging @schmichael now this has a first approval!

@nickethier nickethier merged commit da93f82 into hashicorp:master Sep 3, 2019
@nickethier
Copy link
Member

Thanks @pete-woods!!

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants